$j.ready - Code Metrics - Inspection of "Move doorhanger to iframe. Closes #41" - nextcloud/passman-webextension - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#50)

by Sander

created 2017-04-28 12:15 UTC

$j.ready B

↳ Parent: js/background/inject/inject.js

Complexity

Conditions	1
Paths	2

Size

Total Lines

268

Duplication

Lines	0
Ratio	0 %

Importance

Changes	7
Bugs	0	Features	0

Metric	Value
cc	1
c	7
b	0
f	0
nc	2
nop	0
dl	0
loc	268
rs	8.2857

18 Functions

Rating	Size	Complexity
A	7	2
A	12	1
A	3	1
A	5	1
B	26	3
B	38	3
A	7	2
A	12	4
A	13	2
A	7	1
A	4	1
A	6	2
A	15	2
A	16	2
B	41	1
A	10	1
A	6	2
A	5	1

How to fix Long Method

/* global API */
var $j = jQuery.noConflict();

$j(document).ready(function () {
    var _this = this;
    Array.prototype.findUrl = function (match) {

        return this.filter(function (item) {
            return typeof item === 'string' && item.indexOf(match) > -1;
        });
    };

    function removePasswordPicker() {
        $j('.passwordPickerIframe').remove();
    }

    _this.removePasswordPicker = removePasswordPicker;

    function enterLoginDetails(login) {
        var username;

        if (login.hasOwnProperty('username')) {
            username = (login.username.trim() !== '' ) ? login.username : login.email;
        }

        fillPassword(username, login.password);

        if ($j('.passwordPickerIframe').is(':visible')) {
            removePasswordPicker();
        }
    }

    _this.enterLoginDetails = enterLoginDetails;


    function showPasswordPicker(form) {
        if ($j('.passwordPickerIframe').length > 1) {
            return;
        }
        var loginField = $j(form[0]);
        var loginFieldPos = loginField.offset();
        var position = $j(form[1]).position();

        var passwordField = $j(form[1]);
        var passwordFieldPos = passwordField.offset();

        var left = loginFieldPos.left;
        var top = loginFieldPos.top;
        var maxZ = Math.max.apply(null,
            $j.map($j('body *'), function (e) {
                if ($j(e).css('position') !== 'static')
function isBig(a) {
    if (a > 5000) {
        return "yes";
    }
}

console.log(isBig(5001)); //returns yes
console.log(isBig(42)); //returns undefined
                    return parseInt($j(e).css('z-index')) || 1;
if (a > 0)
    b = 42;
            }));
        if (passwordFieldPos.top > loginFieldPos.top) {
            //console.log('login fields below each other')
            top = passwordFieldPos.top + passwordField.height() + 10;

        } else {
            // console.log('login fields next to each other')
            top = top + loginField.height() + 10;
        }


        var pickerUrl = API.extension.getURL('/html/inject/password_picker.html');

        var picker = $j('<iframe class="passwordPickerIframe" scrolling="no" height="400" width="350" frameborder="0" src="' + pickerUrl + '"></iframe>');
        picker.css('position', 'absolute');
        picker.css('left', left);
        picker.css('z-index', maxZ);
        picker.css('top', top);
        $j('body').append($j(picker));
        // picker.css('width', $j(form).width());
        $j('.passwordPickerIframe:not(:last)').remove();
    }

    function createFormIcon(el, form) {
        var offset = el.offset();

        var width = el.width();
        var height = el.height() * 1;
        var margin = (el.css('margin')) ? parseInt(el.css('margin').replace('px', '')) : 0;

        var padding = (el.css('padding')) ? parseInt(el.css('padding').replace('px', '')) : 0;


        var pickerIcon = API.extension.getURL('/icons/icon.svg');
        $j(el).css('background-image', 'url("' + pickerIcon + '")');
        $j(el).css('background-repeat', 'no-repeat');
        $j(el).css('background-position', 'right 3px center');


        function onClick(e) {
            e.preventDefault();
            var offsetX = e.offsetX;
            var offsetRight = (width - offsetX);
            if (offsetRight < height) {
                showPasswordPicker(form);
            }
        }

        // $j(el).bind('click', onClick);
        $j(el).click(onClick);

    }

    function createPasswordPicker(form) {
        for (var i = 0; i < form.length; i++) {
            var el = $j(form[i]);
            createFormIcon(el, form);

        }
    }

    function formSubmitted(fields) {
        var user = fields[0].value;
        var pass = fields[1].value;
        var params = {
            username: user,
            password: pass
        };
        //Disable password mining
        //$j(fields[1]).attr('type', 'hidden');
        API.runtime.sendMessage(API.runtime.id, {method: "minedForm", args: params});

    }

    function inIframe() {
        try {
            return window.self !== window.top;
        } catch (e) {
            return true;
        }
    }

    function showDoorhanger(data) {
        if (inIframe()) {
            return;
        }
        data.data.currentLocation = window.location.href;
        API.runtime.sendMessage(API.runtime.id, {method: "setDoorhangerData", args: data});
        var pickerUrl = API.extension.getURL('/html/inject/doorhanger.html');

        var doorhanger = $j('<iframe id="password-toolbarIframe" style="display: none;" scrolling="no" height="80" width="100%" frameborder="0" src="' + pickerUrl + '"></iframe>');
        $j('#password-toolbarIframe').remove();
        $j('body').after(doorhanger);
        $j('#password-toolbarIframe').slideDown();
    }

    _this.showDoorhanger = showDoorhanger;

    function showUrlUpdateDoorhanger(data) {
        var buttons = ['cancel', 'updateUrl'];
        showDoorhanger({
            data: data.data,
            buttons: buttons
        });
    }

    _this.showUrlUpdateDoorhanger = showUrlUpdateDoorhanger;

    function checkForMined() {
        if (inIframe()) {
            return;
        }

        API.runtime.sendMessage(API.runtime.id, {method: "getMinedData"}).then(function (data) {
            if (!data) {
                return;
            }
            if (data.hasOwnProperty('username') && data.hasOwnProperty('password') && data.hasOwnProperty('url')) {
                var buttons = [ 'cancel', 'save', 'ignore'];
                showDoorhanger({data: data, buttons: buttons});
            }
        });
    }



    function closeDoorhanger() {
        $j('#password-toolbarIframe').slideUp(400, function () {
            $j('#password-toolbarIframe').remove();
        });
    }
    _this.closeDoorhanger = closeDoorhanger;

    function initForms() {
        API.runtime.sendMessage(API.runtime.id, {method: 'getRuntimeSettings'}).then(function (result) {
            var disablePasswordPicker = result.disablePasswordPicker;
            var url = window.location.href;
            var loginFields = getLoginFields();
            if (loginFields.length > 0) {
                for (var i = 0; i < loginFields.length; i++) {
                    var form = getFormFromElement(loginFields[i][0]);
                    if (!disablePasswordPicker) {
                        createPasswordPicker(loginFields[i], form);

                    }
                    //Password miner
                    /* jshint ignore:start */
                    if (!result.hasOwnProperty('ignored_sites') || result.ignored_sites.findUrl(url) !== -1) {
                        $j(form).submit((function (loginFields) {
                            return function () {
                                formSubmitted(loginFields);
                            };
                        })(loginFields[i]));
                    }
                    /* jshint ignore:end */
                }

                API.runtime.sendMessage(API.runtime.id, {
                    method: "getCredentialsByUrl",
                    args: url
                }).then(function (logins) {
                    console.log('Found ' + logins.length + ' logins for this site');

                    if (logins.length === 1) {
                        API.runtime.sendMessage(API.runtime.id, {method: 'isAutoFillEnabled'}).then(function (isEnabled) {
                            if (isEnabled) {
                                enterLoginDetails(logins[0]);
                            }
                        });
                    }

                });
            }

        });
    }

    function minedLoginSaved(args) {
        // If the login added by the user then this is true
        if (args.selfAdded) {
            enterLoginDetails(args.credential);
        }
    }
    _this.minedLoginSaved = minedLoginSaved;

    function copyText(text) {
        var txtToCopy = document.createElement('input');
        txtToCopy.style.left = '-300px';
        txtToCopy.style.position = 'absolute';
        txtToCopy.value = text;
        document.body.appendChild(txtToCopy);
        txtToCopy.select();
        document.execCommand('copy');
        txtToCopy.parentNode.removeChild(txtToCopy);
    }

    _this.copyText = copyText;

    function init() {
        checkForMined();
        initForms();
    }

    var readyStateCheckInterval = setInterval(function () {
        if (document.readyState === "complete") {
            clearInterval(readyStateCheckInterval);
            API.runtime.sendMessage(API.runtime.id, {method: 'getMasterPasswordSet'}).then(function (result) {
                if (result) {
                    init();
                    // var body = document.getElementsByTagName('body')[0];
                    // observeDOM(body, function () {
                    //     initForms();
                    // });
                } else {
                    console.log('[Passman extension] Stopping, vault key not set');

                }
            });
        }
    }, 10);

    API.runtime.onMessage.addListener(function (msg, sender) {
        //console.log('Method call', msg.method);
        if (_this[msg.method]) {
            _this[msg.method](msg.args, sender);
        }
    });
});

Rating	Size	Complexity
A	7	2
A	12	1
A	3	1
A	5	1
B	26	3
B	38	3
A	7	2
A	12	4
A	13	2
A	7	1
A	4	1
A	6	2
A	15	2
A	16	2
B	41	1
A	10	1
A	6	2
A	5	1

1			/* global API */
2			var $j = jQuery.noConflict();
3
4			$j(document).ready(function () {
5			var _this = this;
6			Array.prototype.findUrl = function (match) {
			0 ignored issues – show Compatibility Best Practice introduced 2017-04-15 16:09 UTC by Report Bug Copy Issue Report You are extending the built-in type `Array`. This may have unintended consequences on other objects using this built-in type. Consider subclassing instead. Loading history...
7			return this.filter(function (item) {
8			return typeof item === 'string' && item.indexOf(match) > -1;
9			});
10			};
11
12			function removePasswordPicker() {
13			$j('.passwordPickerIframe').remove();
14			}
15
16			_this.removePasswordPicker = removePasswordPicker;
17
18			function enterLoginDetails(login) {
19			var username;
20
21			if (login.hasOwnProperty('username')) {
22			username = (login.username.trim() !== '' ) ? login.username : login.email;
23			}
24
25			fillPassword(username, login.password);
			0 ignored issues – show Bug introduced 2017-04-20 18:35 UTC by Report Bug Copy Issue Report The variable `username` does not seem to be initialized in case `login.hasOwnProperty("username")` on line `21` is `false`. Are you sure the function `fillPassword` handles `undefined` variables? Loading history...
26			if ($j('.passwordPickerIframe').is(':visible')) {
27			removePasswordPicker();
28			}
29			}
30
31			_this.enterLoginDetails = enterLoginDetails;
32
33
34			function showPasswordPicker(form) {
35			if ($j('.passwordPickerIframe').length > 1) {
36			return;
37			}
38			var loginField = $j(form[0]);
39			var loginFieldPos = loginField.offset();
40			var position = $j(form[1]).position();
			0 ignored issues – show Unused Code introduced 2017-02-09 16:38 UTC by Report Bug Copy Issue Report The assignment to variable `position` seems to be never used. Consider removing it. Loading history...
41			var passwordField = $j(form[1]);
42			var passwordFieldPos = passwordField.offset();
43
44			var left = loginFieldPos.left;
45			var top = loginFieldPos.top;
46			var maxZ = Math.max.apply(null,
47			$j.map($j('body *'), function (e) {
48			if ($j(e).css('position') !== 'static')
			0 ignored issues – show Complexity Best Practice introduced 2017-04-20 18:35 UTC by Report Bug Copy Issue Report There is no return statement if `$j(e).css("position") !== "static"` is `false`. Are you sure this is correct? If so, consider adding `return;` explicitly. This check looks for functions where a `return` statement is found in some execution paths, but not in all. Consider this little piece of code function isBig(a) { if (a > 5000) { return "yes"; } } console.log(isBig(5001)); //returns yes console.log(isBig(42)); //returns undefined The function `isBig` will only return a specific value when its parameter is bigger than 5000. In any other case, it will implicitly return `undefined`. This behaviour may not be what you had intended. In any case, you can add a `return undefined` to the other execution path to make the return value explicit. Loading history...
49			return parseInt($j(e).css('z-index')) \|\| 1;
			0 ignored issues – show Coding Style Best Practice introduced 2017-04-20 16:51 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
50			}));
51			if (passwordFieldPos.top > loginFieldPos.top) {
52			//console.log('login fields below each other')
53			top = passwordFieldPos.top + passwordField.height() + 10;
54
55			} else {
56			// console.log('login fields next to each other')
57			top = top + loginField.height() + 10;
58			}
59
60
61			var pickerUrl = API.extension.getURL('/html/inject/password_picker.html');
62
63			var picker = $j('<iframe class="passwordPickerIframe" scrolling="no" height="400" width="350" frameborder="0" src="' + pickerUrl + '"></iframe>');
64			picker.css('position', 'absolute');
65			picker.css('left', left);
66			picker.css('z-index', maxZ);
67			picker.css('top', top);
68			$j('body').append($j(picker));
69			// picker.css('width', $j(form).width());
70			$j('.passwordPickerIframe:not(:last)').remove();
71			}
72
73			function createFormIcon(el, form) {
74			var offset = el.offset();
			0 ignored issues – show Unused Code introduced 2017-04-08 15:18 UTC by Report Bug Copy Issue Report The assignment to variable `offset` seems to be never used. Consider removing it. Loading history...
75			var width = el.width();
76			var height = el.height() * 1;
77			var margin = (el.css('margin')) ? parseInt(el.css('margin').replace('px', '')) : 0;
			0 ignored issues – show Unused Code introduced 2017-04-08 15:18 UTC by Report Bug Copy Issue Report The variable `margin` seems to be never used. Consider removing it. Loading history...
78			var padding = (el.css('padding')) ? parseInt(el.css('padding').replace('px', '')) : 0;
			0 ignored issues – show Unused Code introduced 2017-04-08 15:18 UTC by Report Bug Copy Issue Report The variable `padding` seems to be never used. Consider removing it. Loading history...
79
80			var pickerIcon = API.extension.getURL('/icons/icon.svg');
81			$j(el).css('background-image', 'url("' + pickerIcon + '")');
82			$j(el).css('background-repeat', 'no-repeat');
83			$j(el).css('background-position', 'right 3px center');
84
85
86			function onClick(e) {
87			e.preventDefault();
88			var offsetX = e.offsetX;
89			var offsetRight = (width - offsetX);
90			if (offsetRight < height) {
91			showPasswordPicker(form);
92			}
93			}
94
95			// $j(el).bind('click', onClick);
96			$j(el).click(onClick);
97
98			}
99
100			function createPasswordPicker(form) {
101			for (var i = 0; i < form.length; i++) {
102			var el = $j(form[i]);
103			createFormIcon(el, form);
104
105			}
106			}
107
108			function formSubmitted(fields) {
109			var user = fields[0].value;
110			var pass = fields[1].value;
111			var params = {
112			username: user,
113			password: pass
114			};
115			//Disable password mining
116			//$j(fields[1]).attr('type', 'hidden');
117			API.runtime.sendMessage(API.runtime.id, {method: "minedForm", args: params});
118
119			}
120
121			function inIframe() {
122			try {
123			return window.self !== window.top;
124			} catch (e) {
125			return true;
126			}
127			}
128
129			function showDoorhanger(data) {
130			if (inIframe()) {
131			return;
132			}
133			data.data.currentLocation = window.location.href;
134			API.runtime.sendMessage(API.runtime.id, {method: "setDoorhangerData", args: data});
135			var pickerUrl = API.extension.getURL('/html/inject/doorhanger.html');
136
137			var doorhanger = $j('<iframe id="password-toolbarIframe" style="display: none;" scrolling="no" height="80" width="100%" frameborder="0" src="' + pickerUrl + '"></iframe>');
138			$j('#password-toolbarIframe').remove();
139			$j('body').after(doorhanger);
140			$j('#password-toolbarIframe').slideDown();
141			}
142
143			_this.showDoorhanger = showDoorhanger;
144
145			function showUrlUpdateDoorhanger(data) {
146			var buttons = ['cancel', 'updateUrl'];
147			showDoorhanger({
148			data: data.data,
149			buttons: buttons
150			});
151			}
152
153			_this.showUrlUpdateDoorhanger = showUrlUpdateDoorhanger;
154
155			function checkForMined() {
156			if (inIframe()) {
157			return;
158			}
159
160			API.runtime.sendMessage(API.runtime.id, {method: "getMinedData"}).then(function (data) {
161			if (!data) {
162			return;
163			}
164			if (data.hasOwnProperty('username') && data.hasOwnProperty('password') && data.hasOwnProperty('url')) {
165			var buttons = [ 'cancel', 'save', 'ignore'];
166			showDoorhanger({data: data, buttons: buttons});
167			}
168			});
169			}
170
171
172
173			function closeDoorhanger() {
174			$j('#password-toolbarIframe').slideUp(400, function () {
175			$j('#password-toolbarIframe').remove();
176			});
177			}
178			_this.closeDoorhanger = closeDoorhanger;
179
180			function initForms() {
181			API.runtime.sendMessage(API.runtime.id, {method: 'getRuntimeSettings'}).then(function (result) {
182			var disablePasswordPicker = result.disablePasswordPicker;
183			var url = window.location.href;
184			var loginFields = getLoginFields();
185			if (loginFields.length > 0) {
186			for (var i = 0; i < loginFields.length; i++) {
187			var form = getFormFromElement(loginFields[i][0]);
188			if (!disablePasswordPicker) {
189			createPasswordPicker(loginFields[i], form);
			0 ignored issues – show Bug introduced 2017-02-09 16:38 UTC by Report Bug Copy Issue Report The call to `createPasswordPicker` seems to have too many arguments starting with `form`. Loading history...
190			}
191			//Password miner
192			/* jshint ignore:start */
193			if (!result.hasOwnProperty('ignored_sites') \|\| result.ignored_sites.findUrl(url) !== -1) {
194			$j(form).submit((function (loginFields) {
195			return function () {
196			formSubmitted(loginFields);
197			};
198			})(loginFields[i]));
199			}
200			/* jshint ignore:end */
201			}
202
203			API.runtime.sendMessage(API.runtime.id, {
204			method: "getCredentialsByUrl",
205			args: url
206			}).then(function (logins) {
207			console.log('Found ' + logins.length + ' logins for this site');
			0 ignored issues – show Debugging Code introduced 2017-04-20 16:48 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
208			if (logins.length === 1) {
209			API.runtime.sendMessage(API.runtime.id, {method: 'isAutoFillEnabled'}).then(function (isEnabled) {
210			if (isEnabled) {
211			enterLoginDetails(logins[0]);
212			}
213			});
214			}
215
216			});
217			}
218
219			});
220			}
221
222			function minedLoginSaved(args) {
223			// If the login added by the user then this is true
224			if (args.selfAdded) {
225			enterLoginDetails(args.credential);
226			}
227			}
228			_this.minedLoginSaved = minedLoginSaved;
229
230			function copyText(text) {
231			var txtToCopy = document.createElement('input');
232			txtToCopy.style.left = '-300px';
233			txtToCopy.style.position = 'absolute';
234			txtToCopy.value = text;
235			document.body.appendChild(txtToCopy);
236			txtToCopy.select();
237			document.execCommand('copy');
238			txtToCopy.parentNode.removeChild(txtToCopy);
239			}
240
241			_this.copyText = copyText;
242
243			function init() {
244			checkForMined();
245			initForms();
246			}
247
248			var readyStateCheckInterval = setInterval(function () {
249			if (document.readyState === "complete") {
250			clearInterval(readyStateCheckInterval);
251			API.runtime.sendMessage(API.runtime.id, {method: 'getMasterPasswordSet'}).then(function (result) {
252			if (result) {
253			init();
254			// var body = document.getElementsByTagName('body')[0];
255			// observeDOM(body, function () {
256			// initForms();
257			// });
258			} else {
259			console.log('[Passman extension] Stopping, vault key not set');
			0 ignored issues – show Debugging Code introduced 2017-02-09 16:38 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
260			}
261			});
262			}
263			}, 10);
264
265			API.runtime.onMessage.addListener(function (msg, sender) {
266			//console.log('Method call', msg.method);
267			if (_this[msg.method]) {
268			_this[msg.method](msg.args, sender);
269			}
270			});
271			});

Rating	Size	Complexity
A	7	2
A	12	1
A	3	1
A	5	1
B	26	3
B	38	3
A	7	2
A	12	4
A	13	2
A	7	1
A	4	1
A	6	2
A	15	2
A	16	2
B	41	1
A	10	1
A	6	2
A	5	1

nextcloud / passman-webextension

Pull Request — master (#50)

$j.ready B

Complexity

Size

Duplication

Importance

18 Functions

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

Rating	Size	Complexity
A	7	2
A	12	1
A	3	1
A	5	1
B	26	3
B	38	3
A	7	2
A	12	4
A	13	2
A	7	1
A	4	1
A	6	2
A	15	2
A	16	2
B	41	1
A	10	1
A	6	2
A	5	1